Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca2251 #24463

Merged
merged 12 commits into from
Jul 12, 2021
Merged

Ca2251 #24463

merged 12 commits into from
Jul 12, 2021

Conversation

NewellClark
Copy link
Contributor

@NewellClark NewellClark commented May 31, 2021

Summary

Add docs for CA2251 (PR)

Tracking issue

Comment on lines 13 to 15
dev_langs:
- CSharp
- VB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When there is no code snippets in the article, the dev_langs is better to be removed.

@BillWagner BillWagner modified the milestones: June 2021, July 2021 Jul 6, 2021
@gewarren
Copy link
Contributor

gewarren commented Jul 8, 2021

@NewellClark Can you apply the suggestions and resolve the conflicts?

@NewellClark
Copy link
Contributor Author

@gewarren Sorry for delay. I'll apply fixes today.

NewellClark and others added 3 commits July 11, 2021 17:38
Apply suggested changes

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the build warnings.

docs/fundamentals/code-analysis/quality-rules/ca2251.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca2251.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca2251.md Outdated Show resolved Hide resolved
NewellClark and others added 2 commits July 12, 2021 11:33
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@gewarren gewarren closed this Jul 12, 2021
@gewarren gewarren reopened this Jul 12, 2021
@gewarren gewarren closed this Jul 12, 2021
@gewarren gewarren reopened this Jul 12, 2021
@gewarren gewarren closed this Jul 12, 2021
@gewarren gewarren reopened this Jul 12, 2021
@gewarren gewarren merged commit 9819caf into dotnet:main Jul 12, 2021
@gewarren
Copy link
Contributor

@NewellClark Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants