Skip to content

Conversation

tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Jul 1, 2021

Fixes #20563

@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 1, 2021
@tdykstra tdykstra requested review from CamSoper and layomia July 1, 2021 02:31
@tdykstra tdykstra requested a review from a team July 2, 2021 19:19
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM module build warnings:

Line 0: [Warning] Missing metadata attribute: 'zone_pivot_groups'. To use zone pivots in your file, you must specify the valid pivot group that contains the pivot IDs you want to use.
Line 54: [Warning] Cross reference not found: 'System.Text.Json.Node.JsonNode'.

@tdykstra tdykstra merged commit c8bdf67 into dotnet:main Jul 8, 2021
@tdykstra tdykstra deleted the stjthreadsafety branch July 8, 2021 19:26
tdykstra added a commit that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add documentation for thread-safety guarantees of JsonDocument (and related types)

3 participants