C# reference: Consolidate the selection statements articles #25520
Conversation
pkulikov
requested review from
BillWagner,
gewarren,
IEvangelist and
a team
as code owners
| @@ -46,25 +46,3 @@ public class MyClass | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| ## Example of void method | |||
There was a problem hiding this comment.
This example doesn't fit the article anymore as it generates CS8119 error
There was a problem hiding this comment.
Thanks @pkulikov This is really good as well.
I have a few small nits to address, and then this is ready to 
Commenting so it stays in my queue to review
| --- | ||
| # Selection statements (C# reference) | ||
|
|
||
| The following statements select statements to execute out of a number of possible statements based on the value of an expression: |
There was a problem hiding this comment.
typo, I think:
Updated suggestion based on the conversation here.
There was a problem hiding this comment.
@BillWagner no, not a typo. The switch statement executes several statements (all those in one section). if statement always selects one, because technically the whole block {...} is considered as one embedded statement.
Should it be:
...select statements to execute FROM a number of possible statements...
?
There was a problem hiding this comment.
Thanks for clarifying. I like your change here.
docs/csharp/language-reference/statements/selection-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/selection-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/selection-statements.md
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/statements/selection-statements.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
|
@BillWagner thank you for the review. I've applied all your suggestions except the first one. Please check my latest commit, in which I've made more changes based on your feedback. |
Contributes to #10746 (I think it would be better to have two separate articles for selection and jump statements)