Remove core clr hosting #25818
Merged
Remove core clr hosting #25818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hosting .NET through `coreclr.h` has been obsolete since .NET Core 3.0 and should not be used. All the versions which needed it (.NET Core 2.2 and older) are not out of support. Having the `coreclr.h` hosting available in the docs and samples is confusing and may lead people to actually use it for newer runtimes which can lead to unexpected results. This change removes the sample code and modifies the hosting guide to only mention one hosting API. I added a note about the older runtimes needing to use `coreclr.h` but intentionally didn't include any details on that topic.
mateoatr
reviewed
Aug 26, 2021
mateoatr
reviewed
Aug 26, 2021
.../snippets/core/tutorials/netcore-hosting/csharp/HostWithHostFxr/src/NativeHost/inc/hostfxr.h
Outdated
Show resolved
Hide resolved
elinor-fung
reviewed
Aug 26, 2021
Co-authored-by: Elinor Fung <elfung@microsoft.com> Co-authored-by: Mateo Torres-Ruiz <mateoatr@users.noreply.github.com>
|
dotnet/samples#4790 moves the sample one level up in directory - this change already reacts to that and updates the link. |
mateoatr
approved these changes
Aug 27, 2021
elinor-fung
approved these changes
Aug 27, 2021
|
Thats what dot net is made from! no outdating that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hosting .NET through
coreclr.hhas been obsolete since .NET Core 3.0 and should not be used.All the versions which needed it (.NET Core 2.2 and older) are now out of support.
Having the
coreclr.hhosting available in the docs and samples is confusing and may lead people to actually use it for newer runtimes which can lead to unexpected results.This change removes the sample code and modifies the hosting guide to only mention one hosting API. I added a note about the older runtimes needing to use
coreclr.hbut intentionally didn't include any details on that topic.It also updates the
hostfxrsample with a fresh copy of the sample from the samples repo.Corresponding changes to samples: dotnet/samples#4786.