-
Notifications
You must be signed in to change notification settings - Fork 6k
Add ListView breaking change #26249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ListView breaking change #26249
Conversation
docs/core/compatibility/windows-forms/6.0/listview-invalidoperationexception.md
Show resolved
Hide resolved
|
||
## New behavior | ||
|
||
The same code from the [Previous behavior](#previous-behavior) section produces an <xref:System.InvalidOperationException> with the following message: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous/new behavior sections don't show anything about the handle being created or not. Is there a way to show that in the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergeySmirnov-Akvelon to confirm on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially, the issue was reproduced only when the Handle
was created. The presence of the Handle
caused an additional thread of code to be called, which tried to access the Items
and failed because access to Items
in virtual mode was denied. The user did not see any information about the Handle
, only an exception with access to Items
.
Now, since the virtual mode is always checked, we also display an error only about the virtual mode, without any data about the Handle
.
docs/core/compatibility/windows-forms/6.0/listview-invalidoperationexception.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for reviewing. This will go live probably tomorrow. |
Fixes #26021
Preview