Document missing CAxxxx rules #27885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Jan 19, 2022
There was a problem hiding this comment.
@maryamariyan Would you be able to review CA1727, CA1848, CA2017, CA2253, and CA2254?
For CA1727, I feel I'm not adding any useful information.
For CA1848, I'm almost copying from ASP.NET Core docs.
@jkoritzinsky Would you be able to review CA2256, CA2257, and CA2258?
Also @gewarren for review.
22 tasks
Looking. FYI perhaps you could use the content in this PR to help populate information for the above 5 diagnostics: https://github.com/dotnet/roslyn-analyzers/pull/5244/files |
maryamariyan
approved these changes
Jan 19, 2022
gewarren
approved these changes
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/usage-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Youssef1313
commented
Jan 20, 2022
Youssef1313
commented
Jan 20, 2022
Youssef1313
commented
Jan 20, 2022
Youssef1313
commented
Jan 20, 2022
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/interoperability-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/performance-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/performance-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/performance-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/usage-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/usage-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/usage-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/performance-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/performance-warnings.md
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jan 20, 2022
Youssef1313
commented
Jan 20, 2022
docs/fundamentals/code-analysis/quality-rules/usage-warnings.md
Outdated
Show resolved
Hide resolved
|
@gewarren Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23900
Fixes #27857
Not the best documentation one can write, but at least there are pages that readers can submit feedback about.
https://github.com/dotnet/roslyn-analyzers/blob/main/src/NetAnalyzers/Microsoft.CodeAnalysis.NetAnalyzers.sarif for reference