Create diagnosticsource-instrumentation.md #29254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document explains how to instrument code and consume data with DiagnosticSource/DiagnosticListener
noahfalk
reviewed
May 2, 2022
| ## Consuming Data with DiagnosticListener | ||
|
|
||
| Up until now, this guide has focused on how to instrument code to generate logging | ||
| information. In this section we focus on subscribing and decoding of that information. |
There was a problem hiding this comment.
The title of this article was "Instrument Code ..." so the portion above here seemed on-topic, but below it no longer matches the title. I'd suggest changing the title to something broader (or moving the content about listening to a separate page is an alternative)
| #### Subscribing to DiagnosticListeners | ||
|
|
||
| A `DiagnosticListener` implements the `IObservable<KeyValuePair<string, object>>` interface, so you can | ||
| call `Subscribe()` on it as well. We show how to fill out the previous example: |
There was a problem hiding this comment.
I think the style recommendation for docs is to use 2nd or 3rd person rather than 1st person.
|
Closing pull request because I combined all diagnosticsource documentation into one pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document explains how to instrument code and consume data with DiagnosticSource/DiagnosticListener