Skip to content

Add default for --runtime option #29910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

Add default for --runtime option #29910

merged 1 commit into from
Jun 17, 2022

Conversation

tdykstra
Copy link
Contributor

Fixes #29634

@dotnet-bot dotnet-bot added this to the June 2022 milestone Jun 17, 2022
@tdykstra tdykstra requested review from luisquintanilla and a team June 17, 2022 18:46
BillWagner
BillWagner approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tdykstra

You can :shipit: when ready.

@tdykstra tdykstra merged commit c8c6f67 into main Jun 17, 2022
@tdykstra tdykstra deleted the tdykstra-patch-2 branch June 17, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@luisquintanilla luisquintanilla Awaiting requested review from luisquintanilla

Assignees
No one assigned
Labels
cli/subsvc dotnet-fundamentals/svc
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

Unclear what the default is when --runtime is not specified.
3 participants
@tdykstra @BillWagner @dotnet-bot