-
Notifications
You must be signed in to change notification settings - Fork 6k
Fixes #28385 #29925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fixes #28385 #29925
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3423698
Fixes #28385
rafcon-dev 8d2c733
More relevant property to the use of init
rafcon-dev 90f4c3e
Changed property to more relevant use of init
rafcon-dev 373ac94
Update InitExample3.cs
rafcon-dev 82c37f2
Changed property to more relevant use of init
rafcon-dev b76c2c1
Lowered verbosity
rafcon-dev e416fad
Edit to non working code
rafcon-dev 9bf4c50
Update InitExample3.cs
rafcon-dev fc45ca9
Apply suggestions from code review
BillWagner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletions
10
docs/csharp/language-reference/keywords/snippets/InitExample1.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
class InitExample | ||
class Person_InitExample | ||
{ | ||
private double _seconds; | ||
private int _yearOfBirth; | ||
|
||
public double Seconds | ||
public int YearOfBirth | ||
{ | ||
get { return _seconds; } | ||
init { _seconds = value; } | ||
get { return _yearOfBirth; } | ||
init { _yearOfBirth = value; } | ||
} | ||
} |
4 changes: 2 additions & 2 deletions
4
docs/csharp/language-reference/keywords/snippets/InitExample2.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
class InitExampleAutoProperty | ||
class Person_InitExampleAutoProperty | ||
{ | ||
public double Hours { get; init; } | ||
public int YearOfBirth { get; init; } | ||
} |
10 changes: 5 additions & 5 deletions
10
docs/csharp/language-reference/keywords/snippets/InitExample3.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
class InitExampleExpressionBodied | ||
class Person_InitExampleExpressionBodied | ||
{ | ||
private double _seconds; | ||
private int _yearOfBirth; | ||
|
||
public double Seconds | ||
public int YearOfBirth | ||
{ | ||
get => _seconds; | ||
init => _seconds = value; | ||
get => _yearOfBirth; | ||
init => _yearOfBirth = value; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.