Skip to content

Note about computing rids #30168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2022
Merged

Note about computing rids #30168

merged 2 commits into from
Jul 11, 2022

Conversation

gewarren
Copy link
Contributor

Fixes #30141.

@gewarren gewarren requested a review from a team as a code owner July 11, 2022 19:19
@dotnet-bot dotnet-bot added this to the July 2022 milestone Jul 11, 2022
@gewarren gewarren requested a review from tdykstra July 11, 2022 19:19
tdykstra
tdykstra approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of suggestions

@gewarren @tdykstra
Apply suggestions from code review
6fb0e68 
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
@gewarren gewarren enabled auto-merge (squash) July 11, 2022 21:10
@gewarren
Copy link
Contributor Author

Thanks @tdykstra!

@gewarren gewarren merged commit 6394f21 into dotnet:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2022
Development

Successfully merging this pull request may close these issues.

Clarify RID catalog casing
3 participants
@gewarren @tdykstra @dotnet-bot