Skip to content

Conversation

poojapoojari
Copy link
Contributor

Created this PR for user story-1953530's next 10 articles. Validated the content for freshness and accuracy.
User story link: https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1953530/

@dotnet-bot dotnet-bot added this to the July 2022 milestone Jul 21, 2022
@poojapoojari poojapoojari marked this pull request as draft July 21, 2022 11:55
@poojapoojari
Copy link
Contributor Author

Please note: This PR is still a work in progress. It's not ready for review. I'll mark it as "Ready for review" once all the updates are done.

Thank you!

@poojapoojari poojapoojari marked this pull request as ready for review July 29, 2022 08:52
@poojapoojari poojapoojari marked this pull request as draft August 1, 2022 04:38
@poojapoojari
Copy link
Contributor Author

Hello @mcleblanc, @tdykstra, @adegeo, @gewarren, @IEvangelist,

I've completed my work on the next 10 articles and created this pull request for your final review/approval. If you have questions or feedback, please add it as a comment in the PR. The standard review period is 10 business days. :)

User story link: https://dev.azure.com/mseng/TechnicalContent/_workitems/edit/1953530

Thank you,
Pooja

@poojapoojari poojapoojari marked this pull request as ready for review August 1, 2022 12:28
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @poojapoojari.

When fixing these, you don't need to reply to each suggestion to say that you've fixed it - it will save a bunch of emails for everyone.

@poojapoojari
Copy link
Contributor Author

@gewarren Thank you for your feedback. 😊
I've implemented them. Could you please have a look at the latest changes and provide your final approval/feedback?

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want @tdykstra to review the changes to system-text-json-support.md.

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the system-text-json article. Overall it looks great, I just had a few questions and comments.

@BillWagner BillWagner removed this from the July 2022 milestone Aug 9, 2022
@BillWagner BillWagner added this to the September 2022 milestone Aug 9, 2022
@poojapoojari
Copy link
Contributor Author

Hello @mcleblanc @adegeo @gewarren @IEvangelist @tdykstra,

Could you please have a look at the changes and provide your final approval/feedback for sign-off?

Best regards,
Pooja

@gewarren gewarren merged commit b1c2d24 into dotnet:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants