-
Notifications
You must be signed in to change notification settings - Fork 6k
Update hello-world.yml #31700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hello-world.yml #31700
Conversation
Added 'string' in line 64 for the code to copy into the editor
Hi @Chazzersize The original code was intentional. It was meant to be an assignment, after the initial declaration. Should we make a different change to make that more clear? |
Hi @BillWagner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for chatting with me about this change. I made a couple suggestions. If you accept those, I'll merge this.
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will help the next learner to avoid the mistake I made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this, and working through the conversation @Chazzersize
I agree, this will help readers. I've reviewed everything, and I'll as soon as the build finishes.
You should see the changes on our live site in the next day or two, on our regular publishing cycle.
Added 'string' in line 64 for the code to copy into the editor
Summary
This is the first time ever sending a pull request for me.