Skip to content

Conversation

Chazzersize
Copy link
Contributor

Added 'string' in line 64 for the code to copy into the editor

Summary

This is the first time ever sending a pull request for me.

Added 'string' in line 64 for the code to copy into the editor
@dotnet-bot dotnet-bot added this to the October 2022 milestone Oct 11, 2022
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Oct 11, 2022
@BillWagner
Copy link
Member

Hi @Chazzersize

The original code was intentional. It was meant to be an assignment, after the initial declaration.

Should we make a different change to make that more clear?

@Chazzersize
Copy link
Contributor Author

Hi @Chazzersize

The original code was intentional. It was meant to be an assignment, after the initial declaration.

Should we make a different change to make that more clear?

Hi @BillWagner
Ohhh! I see that now.
Maybe add that specific language from above identifying the terms assignment and initial declaration
Sorry I'm very newb to all of this. Thanks for having patience with me.
Do I need to do anything next?

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for chatting with me about this change. I made a couple suggestions. If you accept those, I'll merge this.

Chazzersize and others added 2 commits October 12, 2022 14:35
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Copy link
Contributor Author

@Chazzersize Chazzersize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will help the next learner to avoid the mistake I made.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this, and working through the conversation @Chazzersize

I agree, this will help readers. I've reviewed everything, and I'll :shipit: as soon as the build finishes.

You should see the changes on our live site in the next day or two, on our regular publishing cycle.

@BillWagner BillWagner enabled auto-merge (squash) October 12, 2022 19:33
@BillWagner BillWagner merged commit b20ba55 into dotnet:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc get-started/subsvc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants