Skip to content

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 13, 2022

@gewarren gewarren marked this pull request as ready for review October 13, 2022 04:18
@gewarren gewarren requested review from BillWagner, IEvangelist and a team as code owners October 13, 2022 04:18
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how I feel about this PR. The first several files are something that should have been included in related content, I'm addressing that concern in #31757. The next several files were something that I recently added, knowing full well that it wasn't included in the content yet. The idea was that I'd come back to it, and at least have it in dotnet/samples (ideally, want to keep those synched). There are so many files that it's really challenging to ensure that there are more situations like that. I'm torn.

@gewarren gewarren requested a review from adegeo as a code owner October 13, 2022 17:17
@gewarren
Copy link
Contributor Author

gewarren commented Oct 13, 2022

@IEvangelist I restored the Dockerfile snippets that you added references for in #31757. I've also created a tag (https://github.com/dotnet/docs/releases/tag/snippet-purge-1022) so you can come back and retrieve any snippets that you might need in the future. Also consider adding unreferenced code snippets to the dotnet/samples repo instead.

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.

@gewarren gewarren merged commit 1a68a8d into dotnet:main Oct 13, 2022
@gewarren gewarren deleted the remove-snippets-5 branch October 13, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants