Skip to content

fix redirection and breadcrumb #34624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Mar 16, 2023

Fix the breadcrumb for the C# "advanced topics" section. There isn't an index in that folder, so defer to the first sub-section and it's overview article.

Fixes #34604

Also, fix the redirection to this same article: The destination must include the trailing "/" to redirect to the (default) index in that folder.

Internal previews

Toggle Expand/Collapse
📄 File 🔗 Preview link
docs/csharp/language-reference/compiler-messages/cs0592.md docs/csharp/language-reference/compiler-messages/cs0592
docs/csharp/language-reference/operators/member-access-operators.md docs/csharp/language-reference/operators/member-access-operators
docs/csharp/language-reference/operators/nameof.md docs/csharp/language-reference/operators/nameof
docs/csharp/misc/cs0182.md docs/csharp/misc/cs0182
docs/csharp/misc/cs0643.md docs/csharp/misc/cs0643
docs/csharp/misc/cs0655.md docs/csharp/misc/cs0655
docs/csharp/misc/cs0657.md docs/csharp/misc/cs0657
docs/csharp/misc/cs0658.md docs/csharp/misc/cs0658
docs/csharp/misc/cs1730.md docs/csharp/misc/cs1730
docs/csharp/programming-guide/concepts/index.md docs/csharp/programming-guide/concepts/index
docs/csharp/programming-guide/index.md docs/csharp/programming-guide/index
docs/csharp/tour-of-csharp/features.md docs/csharp/tour-of-csharp/features
docs/csharp/whats-new/csharp-11.md docs/csharp/whats-new/csharp-11
docs/csharp/whats-new/csharp-version-history.md docs/csharp/whats-new/csharp-version-history
docs/standard/attributes/applying-attributes.md docs/standard/attributes/applying-attributes

Fix the breadcrumb for the C# "advanced topics" section. There isn't an index in that folder, so defer to the first sub-section and it's overview article.

Fixes dotnet#34604

Also, fix the redirection to this same article: The destination must include the training "/" to redirect to the (default) `index` in that folder.
@BillWagner BillWagner requested a review from a team as a code owner March 16, 2023 17:59
@dotnet-bot dotnet-bot added this to the March 2023 milestone Mar 16, 2023
@ghost ghost added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Mar 16, 2023
@BillWagner BillWagner requested a review from tdykstra March 16, 2023 17:59
@BillWagner BillWagner enabled auto-merge (squash) March 16, 2023 17:59
*sigh* I'd misnamed redirects in my previous PR, which resulted in a number of broken links. Replace those mistakes
@BillWagner BillWagner requested a review from gewarren as a code owner March 16, 2023 18:15
"reflections" should be "reflection"
@BillWagner BillWagner merged commit ca3b7f6 into dotnet:main Mar 16, 2023
@BillWagner BillWagner deleted the fix-redirects branch March 16, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Advanced concepts" breadcrumb is broken
4 participants