Clarify CA1860 and CA1827 #36257
Merged
Clarify CA1860 and CA1827 #36257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update docs for CA1827 to refer to the possible ambiguity with CA1860
updated ca 1860 to call out the similarity to the ca1827 analyzer
fix typos
ghost
added
the
community-contribution
fix missing blanks around list
gewarren
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Thanks @Applesauce314. I think we could also update the title of CA1827 to include the parentheses after the method names.
Update title of error Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Accept suggestions Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Accept formatting suggestion Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Accept formatting and wording suggesting Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Accept formatting suggestion Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
gewarren
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
when #75933 was created I had brought up the similarity between the new error (CA1860) and the existing CA1827.
this PR updates the docs for both those analyzers to call out that similarity and reduce the chance of confusion
Internal previews