-
Notifications
You must be signed in to change notification settings - Fork 6k
Document Azure SDK subclient registration #36555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
scottaddie
merged 28 commits into
dotnet:main
from
alexwolfmsft:dependency-injection-subclients
Aug 11, 2023
Merged
Document Azure SDK subclient registration #36555
scottaddie
merged 28 commits into
dotnet:main
from
alexwolfmsft:dependency-injection-subclients
Aug 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
reviewed
Aug 8, 2023
docs/azure/sdk/snippets/dependency-injection/HostBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/HostBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
scottaddie
reviewed
Aug 9, 2023
scottaddie
reviewed
Aug 9, 2023
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
scottaddie
reviewed
Aug 10, 2023
…alexwolfmsft/docs into dependency-injection-subclients
scottaddie
reviewed
Aug 10, 2023
docs/azure/sdk/snippets/dependency-injection/HostApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/HostBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/HostApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/HostBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/HostApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
…alexwolfmsft/docs into dependency-injection-subclients
jsquire
reviewed
Aug 10, 2023
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
jsquire
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left one final suggestion but looks great!
Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
scottaddie
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last round of suggestions. Please also update ms.date
.
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/WebApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/HostBuilder/Program.cs
Outdated
Show resolved
Hide resolved
docs/azure/sdk/snippets/dependency-injection/HostApplicationBuilder/Program.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
#sign-off |
1 similar comment
#sign-off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34621
Summary
Describe your changes here.
Fixes #Issue_Number (if available)
Internal previews