Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update observability-with-otel.md prometheus yaml error #37039

Merged
merged 1 commit into from Sep 11, 2023
Merged

Update observability-with-otel.md prometheus yaml error #37039

merged 1 commit into from Sep 11, 2023

Conversation

WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Sep 11, 2023 •
edited by github-actions bot

@WeihanLi WeihanLi requested review from tommcdon and a team as code owners September 11, 2023 10:29
@dotnet-bot dotnet-bot added this to the September 2023 milestone Sep 11, 2023
@ghost ghost added community-contribution Indicates PR is created by someone from the .NET community. okr-health Content-health KR: Concerns article defects/freshness or build warnings. labels Sep 11, 2023
IEvangelist
IEvangelist approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll :shipit: - thank you 馃檹

@IEvangelist IEvangelist merged commit 5907649 into dotnet:main Sep 11, 2023
8 checks passed
@WeihanLi WeihanLi deleted the patch-1 branch September 11, 2023 11:42
IEvangelist pushed a commit to IEvangelist/docs that referenced this pull request Oct 2, 2023
@WeihanLi @IEvangelist
Update observability-with-otel.md prometheus yaml error (dotnet#37039)
0d71c33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@tommcdon tommcdon Awaiting requested review from tommcdon tommcdon is a code owner

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc okr-health Content-health KR: Concerns article defects/freshness or build warnings.
Projects
None yet
Milestone
September 2023
Development

Successfully merging this pull request may close these issues.

Typo in Prometheus Configuration Example
3 participants
@WeihanLi @IEvangelist @dotnet-bot