Skip to content

STJ: Populate properties #37662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 24, 2023
Merged

STJ: Populate properties #37662

merged 10 commits into from
Oct 24, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Oct 21, 2023

Contributes to #37101

  • Splits out the how-to article into separate serialization/deserialization articles
  • Reorganizes the STJ table of contents to put topics specific to serialization or deserialization under those nodes
  • Adds new article on populating properties
  • Updates the immutability article to include read-only properties
  • Updates the migrate from NewtonSoft article

Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
docs/core/whats-new/dotnet-5.md What's new in .NET 5
docs/csharp/programming-guide/strings/index.md Strings and string literals
docs/standard/serialization/index.md Serialization in .NET
docs/standard/serialization/system-text-json/customize-properties.md How to customize property names and values with System.Text.Json
docs/standard/serialization/system-text-json/deserialization.md How to read JSON as .NET objects (deserialize)
docs/standard/serialization/system-text-json/fields.md docs/standard/serialization/system-text-json/fields
docs/standard/serialization/system-text-json/how-to.md How to write .NET objects as JSON (serialize)
docs/standard/serialization/system-text-json/ignore-properties.md How to ignore properties with System.Text.Json
docs/standard/serialization/system-text-json/immutability.md Use immutable types and properties
docs/standard/serialization/system-text-json/migrate-from-newtonsoft.md Migrate from Newtonsoft.Json to System.Text.Json
docs/standard/serialization/system-text-json/overview.md docs/standard/serialization/system-text-json/overview
docs/standard/serialization/system-text-json/polymorphism.md How to serialize properties of derived classes with System.Text.Json
docs/standard/serialization/system-text-json/populate-properties.md Populate initialized properties
docs/standard/serialization/system-text-json/supported-collection-types.md Supported collection types in System.Text.Json
docs/standard/serialization/system-text-json/use-utf8jsonreader.md docs/standard/serialization/system-text-json/use-utf8jsonreader

@gewarren gewarren requested a review from a team as a code owner October 21, 2023 04:34
@dotnet-bot dotnet-bot added this to the October 2023 milestone Oct 21, 2023
Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending feedback.

@eiriktsarpalis eiriktsarpalis requested a review from krwq October 21, 2023 17:49
@eiriktsarpalis
Copy link
Member

Tagging @krwq for review since he worked on the feature.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

I had one clarifying question, but I'm not certain it's an implementation detail that we shouldn't specify.

@gewarren gewarren merged commit beeb420 into dotnet:main Oct 24, 2023
@gewarren gewarren deleted the even-more-stj branch October 24, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants