Skip to content

SendFile breaking change #37890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2023
Merged

SendFile breaking change #37890

merged 2 commits into from
Nov 7, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 3, 2023 •
edited by github-actions bot
Loading

@dotnet-bot dotnet-bot added this to the November 2023 milestone Nov 3, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Nov 3, 2023
@gewarren gewarren requested review from a team and antonfirsov November 3, 2023 19:19
BillWagner
BillWagner approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

antonfirsov
antonfirsov approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 3cd8c61 into dotnet:main Nov 7, 2023
@gewarren gewarren deleted the sendfile branch November 7, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees

No one assigned

Labels

🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc

Projects

No open projects
.NET 8.0 work items
Status: ✅ Done

Milestone

November 2023

Development

Successfully merging this pull request may close these issues.

[Breaking change]: Socket.SendFile/EndSendFile/SendFileAsync throws NotSupportedException for connectionless sockets

4 participants

@gewarren @BillWagner @antonfirsov @dotnet-bot