Special publish for Preview 2 #39910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify why [<Literal>] matters F# values are immutable, so it is confusing to read about how immutable values becoming "constants" would be helpful. Most of the additions are from https://stackoverflow.com/questions/25472810/how-does-literal-differ-from-other-constants-in-f that helped clear up this topic. * Update literals.md --------- Co-authored-by: Don Syme <dsyme@users.noreply.github.com>
* Freshness pass on constraints Contributes to #39819 Fix all open issues on this article: - #11835: Change the example to specify different interfaces, one generic, one not. - #28647: Explicitly mention records for class and struct constraints. - #28914: Add a list that specifies the order of constraints, and which are mutually exclusive. - #30529: Add a clarifying statement that `new()` still isn't allowed: All structs have parameterless constructors, whether declared or implicit. Update the date, and do an edit pass. * edit pass. Also, put back in the table meant in the first commit. * fix typo
* Freshness pass on access modifiers Contributes to #39819 Perform an edit pass, and address open issues: - Fixes #25518: Explain that all partial declarations must match, and not declaring an accessibility means means it has any declared accessibility on the other declaration. - Fixes #27155 Ret-con this from the day when `record` structs didn't exist. Now, `record` is defined as a modifier on either a `struct` or `class` type. - Fixes #27196: Added clarifying remarks that "type" had meant a "type" declared directly in a namespace. This still has meaning in the programming guide, rather than using the more normative language of the standard. - Fixes #27197: Update the language for clarity. * Fix link, remove table.
* Updates for collection expressions clarity Fixes #39586 This issue lists several elements. Here are the updates for each of them: 1. Add the list of potential interface types that a collection can be converted into. In addition, add an alert that in all cases, the collection is materialzed. 1. I didn't add a lot here. I think the addition about instantiating the collection is enough. 1. The additional list of interfaces as conversion targets has been added. I didn't specify the type generated, because that's an implementation detail that may not be visible, and may change. 1. I added a definition of a *Countable* type in the member access operator article. I linked between both. I don't think more is needed, as this fact is also emphasized in the definition of a *well behaved* collection. 1. Add the definition of a well-behaved collection. Finally, do a general edit pas. * edit pass
* remove programming guide index Contributes to #39819 This file doesn't have any real content. It's also stale. The links are all to items in this section anyway. * Remove dead links Remove links from inside the programming guide to the overview page. In other areas, replace the link with a link to the top of programming guide. * build warnings 2 A couple links were incorrect. * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --------- Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal previews
Toggle expand/collapse