-
Notifications
You must be signed in to change notification settings - Fork 6k
Merge main into live #40038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge main into live #40038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
* paragraph on caller information attributes * that / is important
The math was wrong
--------- Co-authored-by: Amaury Levé <amaury.leve@gmail.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
SSN (Social Security Numbers) in the US are 9 digits, typically in the format of 123-45-6789 so the example was not an accurate depiction.
C# 12 isn't supported in the Try.NET platform yet.
* Update out.md to add a usage example as well as limitations. Update out.md to add a usage example as well as limitations. * Apply suggestions from code review --------- Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
* Edit pass on generics Contributes to #39819 Fixes #29778: Specify that generic type parameters are resolved at compile time. Update date and perform an edit pass. * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --------- Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Freshness pass on comparing strings Fixes #32071: Add a quick table with the string comparison enums. Do an edit pass, and check for accuracy. * Update docs/csharp/how-to/compare-strings.md
* Freshness pass on properties 1. Fixes #32071: Rewrite this paragraph to clarify that the compiler and JIT compiler work together to optimize property accessors. This doesn't say exactly when and what optimizations are performed because the compiler and JIT compiler are continuously being improved. Then, perform an edit pass. * edit pass * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --------- Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Add details about differences between app host, and dotnet host * Apply suggestions from code review Co-authored-by: Jan Kotas <jkotas@microsoft.com> * Apply suggestions from code review * Move content around, edit pass, and acrolinx. * Fix link --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>
* Date, passive voice * freshness and acro * freshness and acro * freshness and acro * Freshness, acro * freshness and acro * freshness and acro * Freshness and acro * freshness and acro * Freshness, acro, and 31596 * freshness * freshness and acro * freshness?
#40040) Remove word to make the wording of the link fit better within the context of the sentence
* Add intro about MSTest * Fix header * Fix path link * Update docs/core/testing/unit-testing-mstest-intro.md * Apply suggestions from code review Co-authored-by: David Pine <david.pine@microsoft.com> --------- Co-authored-by: David Pine <david.pine@microsoft.com>
* Document Microsoft.Testing.Platform Extract from MSTest runner docs elements that are common to all test frameworks built on Microsoft.Testing.Platform * Fix links * nit * Add redirections * Apply suggestions from code review Co-authored-by: David Pine <david.pine@microsoft.com> * Fix errors --------- Co-authored-by: David Pine <david.pine@microsoft.com>
This method is protected, not public. https://learn.microsoft.com/en-us/dotnet/api/orleans.grain.registertimer?view=orleans-7.0
Correctly invoke the OnTokenValidated property instead of TokenValidated method in sample
Fix misleading sentence. The original sentence implied that a `struct` could be declared `static`. That's not legal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't squash-merge this PR.
Internal previews
Toggle expand/collapse
dotnet test