Skip to content

Update migrate-from-newtonsoft.md #40458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

Update migrate-from-newtonsoft.md #40458

merged 2 commits into from
Apr 15, 2024

Conversation

TheJakov
Copy link
Contributor

@TheJakov TheJakov commented Apr 12, 2024 •
edited by github-actions bot
Loading

Newtonsoft.Json v13.0.1

Change - JsonReader and JsonSerializer MaxDepth defaults to 64

Summary

Updating feature comparison.

From Newtonsoft.Json v13.0.1 (latest is v13.0.3), JsonReader and JsonSerializer MaxDepth defaults to 64.

Preview

Newtonsoft.Json feature System.Text.Json equivalent
... ...
Default maximum depth 64, configurable ✔️ Default maximum depth 64, configurable
... ...

Internal previews

📄 File 🔗 Preview link
docs/standard/serialization/system-text-json/migrate-from-newtonsoft.md Migrate from Newtonsoft.Json to System.Text.Json

@TheJakov
Update migrate-from-newtonsoft.md
ff93ab4 
Newtonsoft.Json v13.01

Change - JsonReader and JsonSerializer MaxDepth defaults to 64

https://github.com/JamesNK/Newtonsoft.Json/releases/tag/13.0.1
@TheJakov TheJakov requested a review from gewarren as a code owner April 12, 2024 07:16
@dotnet-bot dotnet-bot added this to the April 2024 milestone Apr 12, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Apr 12, 2024
gewarren
gewarren reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheJakov. Can you also update lines 53 and 152 for .NET 6/.NET 8?

@TheJakov TheJakov requested a review from gewarren April 13, 2024 11:14
@TheJakov
Copy link
Contributor Author

Thanks @TheJakov. Can you also update lines 53 and 152 for .NET 6/.NET 8?

Thanks for noticing @gewarren. 🙌

@gewarren gewarren enabled auto-merge (squash) April 15, 2024 15:26
@gewarren gewarren merged commit 20b3db6 into dotnet:main Apr 15, 2024
@TheJakov TheJakov deleted the patch-1 branch April 15, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren approved these changes

+2 more reviewers

@nsamonik nsamonik nsamonik approved these changes

@avlasi avlasi avlasi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Milestone

April 2024

Development

Successfully merging this pull request may close these issues.

5 participants

@TheJakov @nsamonik @gewarren @avlasi @dotnet-bot