-
Notifications
You must be signed in to change notification settings - Fork 6k
The MMM and MMMM formats may include genitive names. #40823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dotnet-policy-service agree |
Ping @adegeo for review |
@tarekgh Could you review this? |
The changes here look good to me. Can we add extra comment to the changes telling Genitive month names will be selected if the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I added one suggestion that will be great if we can apply it. Thanks for your help with this change!
@tarekgh, I made some minor changes to the description of MMM and MMMM in the custom date and time format strings to tell how genitive name is selected, please take a view. |
Summary
According to this question: https://stackoverflow.com/questions/78446297/why-is-the-month-abbreviated-differently-when-the-date-format-includes-a-slot-fo, the
MMM
andMMMM
formats may retrieve from the genitive names if there is ad
ordd
in the format string.Internal previews