Skip to content

The MMM and MMMM formats may include genitive names. #40823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

geniuszxy
Copy link
Contributor

@geniuszxy geniuszxy commented May 9, 2024

@geniuszxy geniuszxy requested review from adegeo and a team as code owners May 9, 2024 05:32
@dotnet-bot dotnet-bot added this to the May 2024 milestone May 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label May 9, 2024
@geniuszxy
Copy link
Contributor Author

@dotnet-policy-service agree

@BillWagner
Copy link
Member

Ping @adegeo for review

@BillWagner BillWagner modified the milestones: May 2024, June 2024 Jun 7, 2024
@BillWagner BillWagner modified the milestones: June 2024, July 2024 Jul 8, 2024
@BillWagner BillWagner modified the milestones: July 2024, August 2024 Aug 13, 2024
@gewarren
Copy link
Contributor

gewarren commented Sep 5, 2024

@tarekgh Could you review this?

@tarekgh
Copy link
Member

tarekgh commented Sep 5, 2024

The changes here look good to me. Can we add extra comment to the changes telling Genitive month names will be selected if the d or dd shows in the formatting date pattern? https://github.com/tarekgh/runtime/blob/202f26b3fa293187c35f530a56751e791ebb4ca9/src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormat.cs#L377

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added one suggestion that will be great if we can apply it. Thanks for your help with this change!

@geniuszxy
Copy link
Contributor Author

@tarekgh, I made some minor changes to the description of MMM and MMMM in the custom date and time format strings to tell how genitive name is selected, please take a view.

@tarekgh tarekgh merged commit 9c49602 into dotnet:main Sep 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants