Skip to content

Conversation

BartoszKlonowski
Copy link
Contributor

@BartoszKlonowski BartoszKlonowski commented Aug 10, 2024

This pull request closes #41621

It adds the Methods recognized as obsolete section to the article describing the fact that missing Obsolete attribute in the class can be a reason to miss the warning about the actually using the obsolete method.

CC: @rhys-vdw


Internal previews

📄 File 🔗 Preview link
docs/csharp/misc/cs0809.md docs/csharp/misc/cs0809

@BartoszKlonowski BartoszKlonowski requested review from BillWagner and a team as code owners August 10, 2024 20:32
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 10, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates PR is created by someone from the .NET community. label Aug 10, 2024
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BartoszKlonowski

I'll :shipit: now.

@BillWagner BillWagner merged commit a023e93 into dotnet:main Aug 12, 2024
@rhys-vdw
Copy link

Nice work @BartoszKlonowski ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CS0809 should mention that the ObsoleteAttribute will not work if applied to an overidden member only
4 participants