Skip to content

Conversation

adegeo
Copy link
Contributor

@adegeo adegeo commented Aug 13, 2024

Summary

This pull request includes updates to the docs/core/project-sdk/msbuild-props-desktop.md file to reflect changes in the .NET SDK versioning and to remove outdated information.

Updates to .NET SDK Versioning:

  • Updated the ms.date metadata to reflect the new documentation date.
  • Modified the description of the UseWPF property to remove the version-specific reference to .NET 5+.
  • Modified the description of the UseWindowsForms property to remove the version-specific reference to .NET 5+
  • Removed the outdated DisableWinExeOutputInference section.

Fixes #42096

@tdykstra


Internal previews

📄 File 🔗 Preview link
docs/core/project-sdk/msbuild-props-desktop.md docs/core/project-sdk/msbuild-props-desktop

@adegeo adegeo requested review from gewarren and a team as code owners August 13, 2024 17:23
@dotnet-bot dotnet-bot added this to the August 2024 milestone Aug 13, 2024
@adegeo adegeo requested a review from tdykstra August 13, 2024 17:24
@adegeo adegeo enabled auto-merge (squash) August 13, 2024 17:45
@jcotton42
Copy link

Removed the outdated DisableWinExeOutputInference section.

Wouldn’t it be better to just update the section to clarify it only applies to .NET 5, rather than deleting it altogether?

@adegeo adegeo merged commit 25fe583 into main Aug 13, 2024
10 checks passed
@adegeo adegeo deleted the adegeo-42096-msbuild branch August 13, 2024 21:14
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Aug 13, 2024
@adegeo
Copy link
Contributor Author

adegeo commented Aug 13, 2024

For anyone following along, this is being discussed in the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-fundamentals/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisableWinExeOutputInference section incorrectly states it applies to .NET 5 SDK and later
4 participants