Delete test policy that requested review #43195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This policy was a test to see if
mentionUserandrequestReviewworked. The test has been completed. Here's what I found:mentionUserworked if it was the only action to take. (But weirdly, the next day the comment with the @mention had disappeared off the face of the earth.) Test PR.requestReviewworked for a user with write perms who wasn't already the owner of the file in CODEOWNERS. Test PR. I couldn't get it to work for anyone else. And when the actions werementionUserfollowed byrequestReview, onlyrequestReviewworked.