Skip to content

Update diagnostic-port details #45669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Conversation

noahfalk
Copy link
Member

@noahfalk noahfalk commented Apr 8, 2025

  • Include the diagnostic-port option for dotnet-gcdump which previously lacked it
  • Give a bit more detail about how diagnostic-port should be specified for all the tools that currently support it
  • Move the warnings about sharing the TMPDIR to the specific --name and --process-id arguments because it shouldn't be a requirement when specifying a full path using --diagnostic-port

This partially addresses dotnet/diagnostics#4524


Internal previews

📄 File 🔗 Preview link
docs/core/diagnostics/dotnet-counters.md Investigate performance counters (dotnet-counters)
docs/core/diagnostics/dotnet-gcdump.md dotnet-gcdump diagnostic tool - .NET CLI
docs/core/diagnostics/dotnet-trace.md dotnet-trace performance analysis utility

- Include the diagnostic-port option for dotnet-gcdump which previously lacked it
- Give a bit more detail about how diagnostic-port should be specified for all the tools that currently support it
- Move the warnings about sharing the TMPDIR to the specific --name and --process-id arguments because it shouldn't be a requirement when specifying a full path using --diagnostic-port
@noahfalk noahfalk force-pushed the diagnostic_port_docs branch from 90e0de5 to 680199b Compare April 8, 2025 23:47
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@noahfalk
Copy link
Member Author

Thanks @gewarren, all suggestions applied!

@noahfalk noahfalk enabled auto-merge (squash) April 10, 2025 07:53
@noahfalk noahfalk merged commit f3091f7 into dotnet:main Apr 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants