Skip to content

Fix build warnings/suggestions #47432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2025
Merged

Fix build warnings/suggestions #47432

merged 2 commits into from
Jul 17, 2025

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jul 17, 2025 •
edited by github-actions bot
Loading

Contributes to #46530.

Internal previews

📄 File 🔗 Preview link
docs/core/compatibility/aspnet-core/8.0/securitytoken-events.md Security token events return a JsonWebToken
docs/core/extensions/httpclient-http3.md Use HTTP/3 with HttpClient
docs/fundamentals/code-analysis/quality-rules/ca1835.md CA1835: Prefer the memory-based overloads of ReadAsync/WriteAsync methods in stream-based classes
docs/fundamentals/code-analysis/quality-rules/ca2016.md docs/fundamentals/code-analysis/quality-rules/ca2016
docs/fundamentals/code-analysis/quality-rules/ca5404.md CA5404: Do not disable token validation checks
docs/fundamentals/code-analysis/quality-rules/ca5405.md "CA5405: Do not always skip token validation in delegates (code analysis)"
docs/fundamentals/code-analysis/quality-rules/index.md Code quality rules
docs/fundamentals/code-analysis/quality-rules/security-warnings.md Security rules
docs/fundamentals/networking/telemetry/tracing.md docs/fundamentals/networking/telemetry/tracing
docs/machine-learning/how-to-guides/ner-dataset-guide.md How to format data for Named Entity Recognition (NER)

@dotnetrepoman dotnetrepoman bot added this to the July 2025 milestone Jul 17, 2025
@gewarren gewarren enabled auto-merge (squash) July 17, 2025 03:21
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc dotnet-networking/subsvc dotnet-ml/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. labels Jul 17, 2025
BillWagner
BillWagner approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Let's :shipit:

@gewarren gewarren merged commit 712b62c into dotnet:main Jul 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@IEvangelist IEvangelist Awaiting requested review from IEvangelist IEvangelist is a code owner

@luisquintanilla luisquintanilla Awaiting requested review from luisquintanilla luisquintanilla is a code owner

@JakeRadMSFT JakeRadMSFT Awaiting requested review from JakeRadMSFT JakeRadMSFT is a code owner

Assignees
No one assigned
Labels
dotnet-fundamentals/svc dotnet-ml/svc dotnet-networking/subsvc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
Milestone
July 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner