Skip to content

Conversation

Alexbits
Copy link
Contributor

Remove private setters to make a class truly immutable. Otherwise, properties can be updated outside of constructor. This also makes code cleaner.

Summary

Remove private setters

Fixes #Issue_Number (if available)

Remove private setters to make a class truly immutable. Otherwise, properties can be updated outside of constructor. This also makes code cleaner.
@Alexbits Alexbits changed the title Update domain-events-design-implementation.md Remove private setters to make a class truly immutable Mar 23, 2018
Alexbits added a commit to Alexbits/eShopOnContainers that referenced this pull request Mar 23, 2018
Remove private setters to make a class truly immutable. Otherwise, properties can be updated outside of constructor. This also makes code cleaner. Same in docs dotnet/docs#4755
Copy link
Contributor

@jzeferino jzeferino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved since its related to #4742

@mairaw mairaw requested a review from BillWagner March 23, 2018 23:09
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this code as well. We appreciate it.

I've reviewed the changes, and I'll :shipit: now.

ping @CESARDELATORRE so this change gets into the reference application.

@BillWagner BillWagner merged commit 40ba296 into dotnet:master Mar 24, 2018
@BillWagner BillWagner added this to the Sprint 133 (3/17/18 - 4/06/18) milestone Mar 24, 2018
@Alexbits Alexbits deleted the patch-3 branch March 24, 2018 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants