-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix event handler documentation terminology to distinguish between event publishing and subscription #48309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Copilot finished work on behalf of
BillWagner
September 9, 2025 18:56
BillWagner
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for final review after accepting suggestions.
.../visual-basic/programming-guide/language-features/procedures/how-to-call-an-event-handler.md
Outdated
Show resolved
Hide resolved
.../visual-basic/programming-guide/language-features/procedures/how-to-call-an-event-handler.md
Outdated
Show resolved
Hide resolved
.../visual-basic/programming-guide/language-features/procedures/how-to-call-an-event-handler.md
Outdated
Show resolved
Hide resolved
gewarren
approved these changes
Sep 11, 2025
.../visual-basic/programming-guide/language-features/procedures/how-to-call-an-event-handler.md
Outdated
Show resolved
Hide resolved
BillWagner
reviewed
Sep 11, 2025
.../visual-basic/programming-guide/language-features/procedures/how-to-call-an-event-handler.md
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
September 11, 2025 15:17
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dotnet-visualbasic/svc
errors-warnings/subsvc
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Visual Basic documentation for "How to call an event handler" was confusing because it didn't clearly distinguish between the two sides of events:
RaiseEvent
(which actually calls/invokes the event handlers)Handles
/WithEvents
orAddHandler
(which sets up handlers to be called later)Changes Made
Updated main article (
how-to-call-an-event-handler.md
):RaiseEvent
is what actually "calls" the event handlersUpdated cross-references in 4 additional files to reflect the new title:
bc33003.md
)Problem Addressed
The original terminology was misleading:
RaiseEvent
(calls handlers) vsAddHandler
/Handles
(subscribe to events)The documentation now clearly explains that subscribing to events is different from raising them, resolving the conceptual confusion identified in the issue.
Fixes #28033.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews