Skip to content

Conversation

PhilKang0704
Copy link
Contributor

@PhilKang0704 PhilKang0704 commented Sep 10, 2025

Per task: https://dev.azure.com/msft-skilling/Content/_workitems/edit/488186, adding no-loc tag to avoid over-localized issue.


Internal previews

📄 File 🔗 Preview link
docs/standard/data/sqlite/types.md Data types

@PhilKang0704 PhilKang0704 requested a review from a team as a code owner September 10, 2025 13:21
@dotnetrepoman dotnetrepoman bot added this to the September 2025 milestone Sep 10, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc dotnet-data/svc community-contribution Indicates PR is created by someone from the .NET community. labels Sep 10, 2025
@PhilKang0704
Copy link
Contributor Author

@gewarren Would you please review the changes to your article in this PR. Feel free to let me know if you have any concerns.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PhilKang0704

I'll :shipit: now.

@BillWagner BillWagner merged commit f3c2d0a into dotnet:main Sep 10, 2025
12 checks passed
@gewarren
Copy link
Contributor

Normally we would have just code-fenced these per the style guide.

@PhilKang0704
Copy link
Contributor Author

Normally we would have just code-fenced these per the style guide.

@gewarren, thanks for the comments. My thought is that if we have just code-fenced these, the content will appear with a gray background block when presented to the user, whereas adding the no-loc tag doesn’t have any visual impact on the page. Of course, if you think I should follow the style guide and use a code block, I can change it back. But if you think the current approach is also fine, then could we go ahead and push this change live?

@gewarren
Copy link
Contributor

Normally we would have just code-fenced these per the style guide.

@gewarren, thanks for the comments. My thought is that if we have just code-fenced these, the content will appear with a gray background block when presented to the user, whereas adding the no-loc tag doesn’t have any visual impact on the page. Of course, if you think I should follow the style guide and use a code block, I can change it back. But if you think the current approach is also fine, then could we go ahead and push this change live?

I don't think it's worth going back and changing it, but for next time, can you code fence code elements instead? Here's the style guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-data/svc dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants