Skip to content

Add code example for CA1700 rule (#48932) #48933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

Add code example for CA1700 rule (#48932) #48933

merged 2 commits into from
Oct 8, 2025

Conversation

kurnakovv
Copy link
Contributor

@kurnakovv kurnakovv commented Oct 7, 2025 •
edited by github-actions bot
Loading

@kurnakovv kurnakovv requested review from a team and gewarren as code owners October 7, 2025 05:41
@dotnetrepoman dotnetrepoman bot added this to the October 2025 milestone Oct 7, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Oct 7, 2025
MFC349
MFC349 approved these changes Oct 7, 2025
View reviewed changes
Copy link

@MFC349 MFC349 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursor

@MFC349
Copy link

MFC349 commented Oct 7, 2025

@cursor

2 similar comments
@MFC349
Copy link

MFC349 commented Oct 7, 2025

@cursor

@MFC349
Copy link

MFC349 commented Oct 7, 2025

@cursor

@kurnakovv
Copy link
Contributor Author

I'm sorry, I forgot to change class -> enum in comments, now I fix it :)

@kurnakovv kurnakovv requested a review from MFC349 October 7, 2025 07:28
MFC349
MFC349 approved these changes Oct 7, 2025
View reviewed changes
Copy link

@MFC349 MFC349 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursor

MFC349
MFC349 approved these changes Oct 7, 2025
View reviewed changes
Copy link

@MFC349 MFC349 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursor

@MFC349
Copy link

MFC349 commented Oct 7, 2025

@cursor

MFC349
MFC349 approved these changes Oct 7, 2025
View reviewed changes
Copy link

@MFC349 MFC349 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cursor

@MFC349
Copy link

MFC349 commented Oct 7, 2025

@cursor

meaghanlewis
meaghanlewis approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@meaghanlewis meaghanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurnakovv this example LGTM, thank you!

@meaghanlewis meaghanlewis merged commit d416a0e into dotnet:main Oct 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@meaghanlewis meaghanlewis meaghanlewis approved these changes

@gewarren gewarren Awaiting requested review from gewarren gewarren is a code owner

+1 more reviewer

@MFC349 MFC349 MFC349 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Milestone

October 2025

Development

Successfully merging this pull request may close these issues.

Add code example for CA1700 rule

3 participants

@kurnakovv @MFC349 @meaghanlewis