Skip to content

📋 standard metadata updates #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 1, 2018
Merged

📋 standard metadata updates #5097

merged 7 commits into from
May 1, 2018

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented May 1, 2018

Related to #5062

We should merge #5099 first and then see how that with these changes combined look like. But wanted to keep that global change on a separate PR.

@mairaw mairaw added this to the Sprint 135 (4/28/18 - 5/18/18) milestone May 1, 2018
@mairaw mairaw self-assigned this May 1, 2018
@pkulikov
Copy link
Contributor

pkulikov commented May 1, 2018

@mairaw sometimes I've seen ms.assetid being removed from the metadata as well. Whenever I touch metadata, should I keep it or might be removed as well? For example, in #5057 it's removed, but not here.

@mairaw mairaw added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 1, 2018
@mairaw
Copy link
Contributor Author

mairaw commented May 1, 2018

Good question @pkulikov. I've been removing them from content that was created directly on Docs like Core or F#. But I'm keeping that metadata for folders that contain migrated content since that's the key to find the topic in our old system. We should be able to remove them entirely once we address all migration issues. /cc @rpetrusha @BillWagner

@mairaw mairaw changed the title standard metadata updates 📋 standard metadata updates May 1, 2018
@mairaw mairaw changed the title 📋 standard metadata updates WIP 📋 standard metadata updates May 1, 2018
@mairaw mairaw added the WIP label May 1, 2018
@mairaw mairaw removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label May 1, 2018
@pkulikov
Copy link
Contributor

pkulikov commented May 1, 2018

@mairaw thank you for the answer, that's clear. So, it's kind of pre-history for those docs in C# and standard folders.

@mairaw mairaw removed the WIP label May 1, 2018
@mairaw mairaw changed the title WIP 📋 standard metadata updates 📋 standard metadata updates May 1, 2018
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just spot-checked a random assortment of files, and everything seemed to be good, @mairaw. You can merge this when you're ready.

@mairaw mairaw closed this May 1, 2018
@mairaw mairaw reopened this May 1, 2018
@mairaw mairaw merged commit 64ec039 into dotnet:master May 1, 2018
@mairaw mairaw deleted the metadata-standard branch May 1, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants