Removing spaces that break links for LOC #6178
Conversation
v-alje
requested review from
cartermp,
douglaslMS,
mairaw and
rpetrusha
as code owners
| @@ -131,7 +131,7 @@ from (C as c join D as d) cross apply c.Names as e | |||
| from (C as c join D as d) cross apply c.Names as e | |||
| ``` | |||
|
|
|||
| In [!INCLUDE[esql](../../../../../../includes/esql-md.md)] (unlike [!INCLUDE[tsql](../../../../../../includes/tsql-md.md)]), the `FROM` clause only introduces the aliases into scope. Any references to columns (properties) of these collections must be qualified with the alias. | |||
| In [!INCLUDE[esql](../../../../../../includes/esql-md.md)](unlike [!INCLUDE[tsql](../../../../../../includes/tsql-md.md)]), the `FROM` clause only introduces the aliases into scope. Any references to columns (properties) of these collections must be qualified with the alias. | |||
There was a problem hiding this comment.
I'm afraid the most of the changes in this PR remove correct white spaces.
For example, this paragraph is responsible for the following section:
https://docs.microsoft.com/en-us/dotnet/framework/data/adonet/ef/language-reference/from-entity-sql#semantics
In Entity SQL (unlike Transact-SQL), the
FROMclause...
Note that white space is correct.
In general, all structures of the form
[!INCLUDE[<name>](<link>)]
require white space after it.
There was a problem hiding this comment.
I agree with @pkulikov, @v-alje. This can't be a bulk change operation. Along with removal of valid whitespace characters, these changes introduced six build breaks. My sense is that the best approach is to close this PR and submit a new PR that doesn't do a bulk change in eliminating whitespace characters.
| [Previous] (index.md) | ||
| [Next] (../Microsoft-platform-tools-containerized-apps/index.md) | ||
| [Previous](index.md) | ||
| [Next](../Microsoft-platform-tools-containerized-apps/index.md) |
There was a problem hiding this comment.
@v-alje that looks that real issues to fix are in the following folder:
https://github.com/dotnet/docs/tree/master/docs/standard/containerized-lifecycle-architecture
My recommendation to you is to create a new PR that updates the files only from that folder: that one would be much easier to review and most probably it would be the one catching the majority of such mistakes in the docs.
There was a problem hiding this comment.
Please see @pkulikov and @rpetrusha earlier comments. Based on the earlier PRs I saw, the links breaking LOC were the Previous and Next buttons. Can we focus this PR on only those files?
|
@mairaw @pkulikov @rpetrusha |
This is a bulk fix to remove spaces from between the square brackets "]" and the parentheses "(" of markdown links. This fixes a content issue that the Localization team is seeing where loc content is broken compared to English. User Story 1292440
Related to #6169