Skip to content

fixed part identification #6434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2018
Merged

fixed part identification #6434

merged 1 commit into from
Jul 13, 2018

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 13, 2018

Reacting to comment on a previous PR:
#6395 (comment)

@mairaw mairaw self-assigned this Jul 13, 2018
@mairaw mairaw requested a review from rpetrusha as a code owner July 13, 2018 01:59
@mairaw mairaw mentioned this pull request Jul 13, 2018
Merged
rpetrusha
rpetrusha approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mairaw. This is ready to merge.

@rpetrusha rpetrusha merged commit ea82aac into master Jul 13, 2018
@rpetrusha
Copy link
Contributor

Sorry, @mairaw. I inadvertently merged your PR.

@mairaw mairaw deleted the mairaw-patch-3 branch July 13, 2018 18:42
@mairaw
Copy link
Contributor Author

mairaw commented Jul 13, 2018

That's fine. I don't mind @rpetrusha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mairaw mairaw

Labels
dotnet-visualbasic/svc
Projects
None yet
Milestone
Sprint 138 (07/02/2018 - 07/20/2018)
Development

Successfully merging this pull request may close these issues.
3 participants
@mairaw @rpetrusha @BillWagner