Skip to content

cs-interactive now reflects user culture #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2018
Merged

cs-interactive now reflects user culture #6661

merged 1 commit into from
Jul 26, 2018

Conversation

rpetrusha
Copy link
Contributor

cs-interactive now reflects user culture

This PR:

  • Modifies topics that use the C# interactive REPL and that noted the REPL uses the invariant culture to modify the note.
  • Deleted the include file containing the note about the REPL using the invariant culture. (I've confirmed that the file isn't included in any API docs.)

@rpetrusha rpetrusha self-assigned this Jul 25, 2018
BillWagner
BillWagner approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad to see this change. You can :shipit: when ready @rpetrusha

@rpetrusha rpetrusha merged commit 0c62523 into dotnet:master Jul 26, 2018
@rpetrusha rpetrusha deleted the interactive-culture branch July 26, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
Sprint 139 (7/23/2018 - 8/10/2018)
Development

Successfully merging this pull request may close these issues.
2 participants
@rpetrusha @BillWagner