.NET Framework markdig conversion issues, Part 1 #6786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpetrusha
changed the title
added 2 commits
August 2, 2018 08:19
mairaw
approved these changes
Aug 4, 2018
|
|
||
| ``` | ||
| <% @ServiceHost Service="MyNamespace.MyServiceImplementationTypeName" %> | ||
| ``` | ||
|
|
||
| It consists of the [@ServiceHost](../../../../docs/framework/configure-apps/file-schema/wcf-directive/servicehost.md) directive and a single attribute, `Service`. The value of the `Service` attribute is the common language runtime (CLR) type name of the service implementation. Using this directive is basically equivalent to creating a service host using the following code. | ||
| It consists of the \[@ServiceHost](../../../../docs/framework/configure-apps/file-schema/wcf-directive/servicehost.md) directive and a single attribute, `Service`. The value of the `Service` attribute is the common language runtime (CLR) type name of the service implementation. Using this directive is basically equivalent to creating a service host using the following code. |
There was a problem hiding this comment.
The \ needs to be inside the bracket
| @@ -45,7 +45,7 @@ This topic describes the steps required to set up Windows Process Activation Ser | |||
| ``` | |||
|
|
|||
| > [!NOTE] | |||
| > This command is a single line of text. This command enables the /\<*WCF Application*> application to be accessed using both http://localhost*/\<WCF Application>* and net.tcp://localhost/*\<WCF Application>*. | |||
| > This command is a single line of text. This command enables the /\<*WCF Application*> application to be accessed using both `http://localhost`*/\<WCF Application>* and `net.tcp://localhost/`*\<WCF Application>*. | |||
There was a problem hiding this comment.
this renders a bit weird. Maybe it would be better to just have everything inside backticks?
| @@ -51,12 +53,12 @@ public interface ICalculatorSession | |||
|
|
|||
| The service maintains state, using the feature, for each client as multiple service operations are called to perform a calculation. The client can retrieve the current result by calling `Result` and can clear the result to zero by calling `Clear`. | |||
There was a problem hiding this comment.
not related to your change:
formatting on this session here on GitHub diff looks a bit odd. Not sure what's causing that.
line 35 and 62- add language identifier?
| @@ -6,26 +6,26 @@ ms.assetid: 69a21511-0871-4c41-9a53-93110e84d7fd | |||
| # Troubleshooting the Getting Started Tutorial | |||
| This topic lists the most common problems encountered when working through the Getting Started Tutorial and how to resolve them. | |||
|
|
|||
| 1. [I am unable to find the project files on my hard drive.](../../../docs/framework/wcf/troubleshooting-the-getting-started-tutorial.md#BKMK_q1) | |||
| 1. [I am unable to find the project files on my hard drive.](#BKMK_q1) | |||
There was a problem hiding this comment.
not related to your change but this topic looks pretty bad with this layout. The section names look ridiculously long. Wondering if removing this menu from the top and just listing the different problems on a bulleted list could make this look a bit better
added 2 commits
August 6, 2018 10:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Framework markdig conversion issues
Related to #6581