Skip to content

Adjusting WCF performance counters descritpion (Calls Duration) #7474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

ptylenda
Copy link
Contributor

@ptylenda ptylenda commented Sep 4, 2018

Summary

While working on Prometheus integration for WCF services monitoring, I have noticed that https://github.com/dotnet/docs/blob/ee33cc88df5e22a9a8ff6d99b511a642089d38a1/docs/framework/wcf/diagnostics/performance-counters/toc.md has wrong performance counters names for "Calls Duration". Raw output of TypePerf.exe -qx reveals that naming is as following:

\ServiceModelEndpoint 4.0.0.0(xxx@xxx)\Calls Duration
\ServiceModelOperation 4.0.0.0(xxx@xxx)\Calls Duration
\ServiceModelService 4.0.0.0(xxx@xxx)\Calls Duration

Whereas the docs state that it is "Call Duration" (note the missing "s") for all categories.

Note: I am not able to verify if this is specific for a given version of .NET framework, or docs had wrong naming since the beginnig.

@dnfclas
Copy link

dnfclas commented Sep 4, 2018

CLA assistant check
All CLA requirements met.

@rpetrusha rpetrusha added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Sep 4, 2018
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ptylenda, for contributing to the dotnet/docs repo and for noticing that the performance counter name is incorrect. We'll merge your PR now. Your changes should appear live on docs.microsoft.com in the next day or two.

@rpetrusha rpetrusha merged commit e234142 into dotnet:master Sep 4, 2018
@ptylenda
Copy link
Contributor Author

ptylenda commented Sep 7, 2018

@rpetrusha Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants