Skip to content

Update live with current master #7667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 13, 2018
Merged

Update live with current master #7667

merged 7 commits into from
Sep 13, 2018

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Sep 13, 2018

No description provided.

mvelosop and others added 7 commits September 12, 2018 11:03
* Cross updating with eBook v2.1.02

* Fixed revision date, add image captions.

* Fixed, Windows host CAN run Linux containers
* Cross updating with eBook v2.1.02

* Fix revision date

* Add cover caption

* Include @mairaw comments
* visual studio updates

* ron's comments

* remove backticks

* second review - thanks ron

* fix clickonce bookmarks
* CC70761: Asterisk problem at line 43

Hello, @rpetrusha,
This proposed file change comes from https://github.com/dotnet/docs.ko-kr/pull/64 .
Could you review this contribution and help to merge if agreed?
Many thanks in advance.

* Update marshaling-data-with-platform-invoke.md

* Update marshaling-data-with-platform-invoke.md

* Update marshaling-data-with-platform-invoke.md

* Update marshaling-data-with-platform-invoke.md

* Update marshaling-data-with-platform-invoke.md
* bring in the original files from the roslyn wiki

No edits yet.

* stash - switching branches.

* sample updated

* add notes

* final proofread and ready for review

* fix build errors.

* fix links to source code.

* final set of build warnings.

* major rewrite

This has some significant re-writes based on the earlier reviews. It should flow better and keep the user focused on the steps to update the analyzer.

Tests are used as good examples of code that should or should not raise the diagnostic.

* grammar check and proofread

* fix build warnings.

A few mis-placed links.

* respond to feedback

I've updated up to the first run with the code fix.

* respond to feedback

Thanks for the thorough review @Thraka  All the changes have been addressed.
invariannt culture.       Correct to:   invariant culture.
@mairaw mairaw merged commit 76a304c into live Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants