update volatile information #8617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #5763 Relies on dotnet/samples#412
|
closing and reopening to force a new build (the samples PR is merged) |
Thraka
suggested changes
Oct 24, 2018
| [!INCLUDE[CSharplangspec](~/includes/csharplangspec-md.md)] | ||
| [!code-csharp[declareVolatile](~/samples/snippets/csharp/language-reference/keywords/volatile/Program.cs#Volatile)] | ||
|
|
||
| With the `volatile` modifier on the declaration of in place, you'll always get the same results (similar to the excerpt shown in the preceding code). However, without that modifier on the `_shouldStop` member, the behavior is unpredictable. The `DoWork` method may optimize the member access, resulting in reading stale data. Because of the nature of multi-threaded programming, the number of stale reads is unpredictable. Different runs of the program will produce somewhat different results. |
There was a problem hiding this comment.
I think variable names were here but removed. I see double spaces in the first start of the sentence, two of them:
X X
on the declaration of in
pkulikov
reviewed
Oct 25, 2018
| - [C# Reference](../index.md) | ||
| - [C# Programming Guide](../../programming-guide/index.md) | ||
| - [C# Keywords](index.md) | ||
| - [Modifiers](modifiers.md) |
There was a problem hiding this comment.
Links to the lock keyword and xref to the Interlocked would be useful here, for sure.
And maybe that blog post, as well:
https://blogs.msdn.microsoft.com/ericlippert/2011/06/16/atomicity-volatility-and-immutability-are-different-part-three/
|
Updated per feedback. It's ready for another look @Thraka |
The anchor tag was wrong for the volatile section.
BillWagner
force-pushed
the
update-volatile-keyword
branch
from
2f4c735 to
c661fb3
Compare
Thraka
reviewed
Oct 25, 2018
|
LGTM! |
Thraka
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5763
Relies on dotnet/samples#412