Skip to content

Conversation

tannergooding
Copy link
Member

This makes progress towards dotnet/runtime#105981

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics

Copy link

Learn Build status updates of commit d0fae23:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Numerics/Vector.xml ⚠️Warning View Details
xml/System.Numerics/Vector2.xml ⚠️Warning View Details
xml/System.Numerics/Vector3.xml ⚠️Warning View Details
xml/System.Numerics/Vector4.xml ⚠️Warning View Details
xml/System.Numerics/TotalOrderIeee754Comparer`1.xml ✅Succeeded View
xml/System/Double.xml ✅Succeeded View
xml/System/Half.xml ✅Succeeded View
xml/System/Single.xml ✅Succeeded View

xml/System.Numerics/Vector.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.IsPositive(`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MaxMagnitudeNumber(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.Max(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MaxNative(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MaxMagnitude(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MinMagnitudeNumber(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.IsPositiveInfinity(`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MaxNumber(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.Min(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.IsZero(`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MinNative(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MinNumber(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.MinMagnitude(`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.ClampNative(`0,`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.IsNegative(`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.Clamp(`0,`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Single}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.UInt32}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.Clamp(`0,`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.ClampNative(`0,`0,`0)'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Double}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Int64}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Double}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.UInt64}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Runtime.Intrinsics.ISimdVector`2.CopySign(`0,`0)'.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @tannergooding

I'll :shipit: now.

@BillWagner BillWagner merged commit a927f1a into dotnet:main Aug 22, 2024
@tannergooding
Copy link
Member Author

@BillWagner, looks like there were some warnings due to several inheritdoc not being resolvable.

I'll fix those and get a new PR up to ensure the documentation includes all the relevant information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants