Skip to content

Conversation

tannergooding
Copy link
Member

This resolves the warnings introduced in #10292

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tannergooding!

Copy link

Learn Build status updates of commit e16eca7:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Numerics/Vector.xml ⚠️Warning View Details
xml/System.Numerics/Vector2.xml ✅Succeeded View
xml/System.Numerics/Vector3.xml ✅Succeeded View
xml/System.Numerics/Vector4.xml ✅Succeeded View

xml/System.Numerics/Vector.xml

  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Single}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.UInt32}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Double}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Int64}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.Double}'.
  • Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'System.Numerics.Vector{System.UInt64}'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@tannergooding
Copy link
Member Author

@gewarren, there were a couple of pre-existing (prior to #10292) warnings about unresolvable xrefs. I just pushed another commit that resolves them by using the see langword="..." syntax that was agreed upon in the more general discussion

Copy link

Learn Build status updates of commit 07721a8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Numerics/Vector.xml ✅Succeeded View
xml/System.Numerics/Vector2.xml ✅Succeeded View
xml/System.Numerics/Vector3.xml ✅Succeeded View
xml/System.Numerics/Vector4.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@tannergooding tannergooding merged commit 78d872d into dotnet:main Aug 22, 2024
@tannergooding tannergooding deleted the net9-numerics branch August 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants