Skip to content

Conversation

dotnet-policy-service[bot]
Copy link
Contributor

Please don't squash-merge this PR.

apexvss@microsoft.com and others added 12 commits August 27, 2024 15:08
 Build.Reason:Manual by Min Huang
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=450660&view=results
 source_repo.branch:mh/workaround
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
 Build.Reason:Manual by Min Huang
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=451135&view=results
 source_repo.branch:mh/workaround
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Update to remove unexpected `)` characters that don't have a matching `(` character. Also, trim unnecessary nearby spaces.
Changed references to entryNameEncoding to clarify that it changes the encoding and decoding of both entry names and comments.
* Update sample.cs

- Fix first if-statement in Create method: currently checks to see if `nameValue == null` **and** `nameValue.Length == 0`. Should check if one or the other.
- Change exception thrown from above if-statement from `ArgumentNullException` to `ArgumentException` and replaced argument with `nameof` expression.
- Remove unnecessary empty lines.

* Apply suggestions from code review

---------

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
CI Update:  Exclude CollectionsExtensions class from Microsoft.Extensions.DependencyModel.dll
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Aug 29, 2024
Copy link

Learn Build status updates of commit a61db45:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Collections.Generic/CollectionExtensions.xml ⚠️Warning View Details
includes/remarks/System.IO.Compression/ZipArchive/.ctor_Stream_ZipArchiveMode_Boolean_Encoding.md ✅Succeeded View
includes/remarks/System.IO.Compression/ZipFile/Open.md ✅Succeeded View
snippets/csharp/Microsoft.Win32.SafeHandles/SafeWaitHandle/Overview/sample.cs ✅Succeeded View
snippets/csharp/System.Diagnostics/ProcessStartInfo/Verb/source.cs ✅Succeeded View
snippets/csharp/System/Object/GetType/GetTypeEx2.cs ✅Succeeded View
xml/FrameworksIndex/net-6.0.xml ✅Succeeded
xml/FrameworksIndex/net-7.0.xml ✅Succeeded
xml/FrameworksIndex/net-8.0.xml ✅Succeeded
xml/FrameworksIndex/net-9.0.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.6.2.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.2.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.7.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.8.1.xml ✅Succeeded
xml/FrameworksIndex/netframework-4.8.xml ✅Succeeded
xml/FrameworksIndex/netstandard-2.0.xml ✅Succeeded
xml/Microsoft.CSharp/CSharpCodeProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCacheOptions.xml ✅Succeeded View
xml/System.CodeDom.Compiler/CodeDomProvider.xml ✅Succeeded View
xml/System.Collections/ArrayList.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/FeatureGuardAttribute.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/FeatureSwitchDefinitionAttribute.xml ✅Succeeded View
xml/System.Diagnostics/Process.xml ✅Succeeded View
xml/System.Diagnostics/ProcessStartInfo.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.Collections.Generic/CollectionExtensions.xml

  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getdefaultassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getdefaultgroup was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getdefaultruntimefileassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getruntimeassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getruntimefileassets was deleted without redirection. To avoid broken links, add a redirection.
  • [Warning: file-not-redirected - See documentation] File xml/System.Collections.Generic/CollectionExtensions.xml with URL /dotnet/api/system.collections.generic.collectionextensions.getruntimegroup was deleted without redirection. To avoid broken links, add a redirection.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@dotnet-policy-service dotnet-policy-service bot merged commit e7ee3cf into live Aug 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. :octocat: auto-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants