Change NOTE to CAUTION in UTF8Encoding security warning #1965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE is not an important notation, CAUTION is more appropriate for security sensitive warnings. This better matches, for instance, the documentation for BestFitMappingAttribute which contains a CAUTION note about encoding replacement characters changing the interpretation of the string.
rpetrusha
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Thanks, @ReidB-MSFT. Caution is a much better choice than Note. I'll merge your PR now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NOTE is not an important notation, CAUTION is more appropriate for security sensitive warnings. This better matches, for instance, the documentation for BestFitMappingAttribute which contains a CAUTION note about encoding replacement characters changing the interpretation of the string.