Skip to content

Changed NOTE to CAUTION or IMPORTANT #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2019
Merged

Changed NOTE to CAUTION or IMPORTANT #1966

merged 1 commit into from
Feb 28, 2019

Conversation

rpetrusha
Copy link

Changed NOTE to CAUTION or IMPORTANT

This PR:

Related to #1965

//cc @ReidB-MSFT

@rpetrusha rpetrusha added this to the March 2019 milestone Feb 28, 2019
@rpetrusha rpetrusha self-assigned this Feb 28, 2019
mairaw
mairaw approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReidB-MSFT
Copy link
Contributor

Looks good to me as well. Thanks for proactively taking care of these instances!

@rpetrusha rpetrusha merged commit 3cf92d3 into dotnet:master Feb 28, 2019
@rpetrusha rpetrusha deleted the throwoninvalid branch February 28, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mairaw mairaw mairaw approved these changes

Assignees

@rpetrusha rpetrusha

Labels
None yet
Projects
None yet
Milestone
March 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@rpetrusha @ReidB-MSFT @mairaw