Correctly reference UtcNow instead of Now #4215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doco is misleading indicating that when the timer does not use high res it returns DateTime.Now but looking at source code I can see that in fact it returns DateTime.UtcNow, so changed the documentation to reflect this small detail.
|
@krwq can you review? |
|
Looking at .NET Core we seem to have removed the fall back and assert we won't need it but since full framework has that code I'm fine with the change |
krwq
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doco is misleading indicating that when the timer does not use high res it returns DateTime.Now but looking at source code I can see that in fact it returns DateTime.UtcNow, so changed the documentation to reflect this small detail.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)