Skip to content

Replaced DateTime.Now with DateTime.UtcNow in Stopwatch.xml #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Replaced DateTime.Now with DateTime.UtcNow in Stopwatch.xml #4376

wants to merge 1 commit into from
+1 −1

Conversation

devigo
Copy link

@devigo devigo commented Jun 13, 2020

Summary

Replaced DateTime.Now with DateTime.UtcNow, based on the code here

In fact, the following sentence is not relevant starting with .NET Core 3.0 and higher, because the implementation is changed here
image

@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 13, 2020
@gewarren
Copy link
Contributor

@tommcdon @sywhang @krwq Could you review this PR and address the comment in the original description?

@gewarren gewarren requested a review from krwq July 21, 2020 21:59
@krwq
Copy link
Member

krwq commented Jul 23, 2020

I've just merged #4215 which seem identical to this PR

@devigo devigo closed this Aug 2, 2020
@devigo devigo deleted the patch-1 branch August 2, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krwq krwq Awaiting requested review from krwq

Assignees
No one assigned
Labels
area-System.DateTime
Projects
None yet
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@devigo @gewarren @krwq @jeffhandley @dotnet-bot