A small correction on the note about stream size rounded up by page size #4297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The view size cannot be smaller than mapped file size. It is just getting rounded up by page size which is normally 4kb.
|
From dev comment found from github, When MemoryMappedFileOptions.DelayAllocatePages option is used, the view size can be smaller than the mapped file size if memory is not committed. Should this be added as a comment to make this better? |
|
@carlossanlop @jozkee Can you review this PR? |
jeffhandley
approved these changes
Feb 14, 2021
There was a problem hiding this comment.
@shjin404 Sorry this sat for so long. Thank you for making this improvement. I validated the behavior of rounding up based on the source here: https://github.com/dotnet/runtime/blob/master/src/libraries/System.IO.MemoryMappedFiles/src/System/IO/MemoryMappedFiles/MemoryMappedView.Windows.cs#L20-L25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view size cannot be smaller than mapped file size. It is just getting rounded up by page size which is normally 4kb.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)