Fix complete view of the MMF description #5310
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> To create a complete view of the memory-mapped file, specify 0 (zero) for the size parameter. If you do this, the size of the view might be **smaller** or larger than the size of the source file on disk. This is because views are provided in units of system pages, and the size of the view is **rounded up to the next** system page size. Above statement has a small mistake. The view can't be smaller. It is indeed **rounded up** to the page size.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Docs Build status updates of commit 628da3c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
gewarren
requested review from
adamsitnik,
carlossanlop and
jozkee
as code owners
|
Hi @KubaSzostak Big thanks for your contribution! There was another PR opened to address this issue (#4297) and it got already merged, so I am afraid that I have to close this one. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Above statement has a small mistake. The view can't be smaller. It is indeed rounded up to the page size.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)