Skip to content

Conversation

carlossanlop
Copy link
Contributor

Area owners of Microsoft.Extensions.Logging: @maryamariyan @tarekgh

@opbld30
Copy link

opbld30 commented Oct 1, 2020

Docs Build status updates of commit 1ee404d:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml ⚠️Warning View Details
xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/AzureAppServicesDiagnosticsLoggerProvider.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchLoggerConfigureOptions.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchingLogger.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchingLoggerProvider.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BlobAppendReferenceWrapper.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BlobLoggerConfigureOptions.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/ConfigurationBasedLevelSwitcher.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/FileLoggerConfigureOptions.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/WebAppContext.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/WebAppLogConfigurationReader.xml ✅Succeeded

xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.

xml/Microsoft.Extensions.DependencyInjection/PollyServiceCollectionExtensions.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IReadOnlyPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.PolicyRegistry'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Polly.Registry.IPolicyRegistry`1'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@maryamariyan
Copy link
Contributor

Microsoft.Extensions.Logging.AzureAppServices moved to dotnet/aspnetcore (Refer to this). Perhaps their docs don't belong to dotnet/dotnet-docs-api.

@pranavkm @ericstj thoughts?

@ericstj
Copy link
Member

ericstj commented Oct 5, 2020

I don't really have a preference. There are plenty of libraries documented here which don't build out of dotnet/runtime nor dotnet/extensions. @pranavkm what is your preference? Do you want all ASPNet docs in a different repo?

@carlossanlop carlossanlop requested a review from pranavkm October 14, 2020 06:33
…AppContext.xml

Co-authored-by: Maryam Ariyan <maryam.ariyan@microsoft.com>
@opbld34
Copy link

opbld34 commented Oct 14, 2020

Docs Build status updates of commit 6293f9b:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/AzureAppServicesDiagnosticsLoggerProvider.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchLoggerConfigureOptions.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchingLogger.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchingLoggerProvider.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BlobAppendReferenceWrapper.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BlobLoggerConfigureOptions.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/ConfigurationBasedLevelSwitcher.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/FileLoggerConfigureOptions.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/WebAppContext.xml ✅Succeeded
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/WebAppLogConfigurationReader.xml ✅Succeeded

xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@carlossanlop
Copy link
Contributor Author

Warning is happening also in a line unrelated to this PR, @TianqiZhang @joelmartinez :

File Status Preview URL Details
xml/Microsoft.Extensions.Logging.AzureAppServices/BatchingLoggerProvider.xml Warning View Line 0: [Warning] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.Line 0: [Warning] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.Line 0: [Warning] Cross reference not found: 'Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger'.

@carlossanlop carlossanlop merged commit 44ffa45 into dotnet:master Oct 14, 2020
@carlossanlop carlossanlop deleted the M_E_AzureAppServices branch October 14, 2020 20:34
@joelmartinez
Copy link
Contributor

@carlossanlop hmm ... the actual type seems to be in a different namespace than the one mentioned in those warnings:
Microsoft.Extensions.Logging.AzureAppServices.BatchingLogger

https://github.com/dotnet/dotnet-api-docs/blob/6a4a5579c7e5e9161443959ff4b33a2b0b0d9199/xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BatchingLogger.xml
T:Microsoft.Extensions.Logging.AzureAppServices.Internal.BatchingLogger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants